-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: migrate to Vite 6 environment API #634
Open
hi-ogawa
wants to merge
33
commits into
chore-vite-6
Choose a base branch
from
feat-rsc-vite-6
base: chore-vite-6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 29, 2024
hi-ogawa
changed the title
feat!: migrate to Vite 6 environment API (wip)
feat!: migrate to Vite 6 environment API
Aug 29, 2024
hi-ogawa
force-pushed
the
feat-rsc-vite-6
branch
2 times, most recently
from
August 30, 2024 03:30
06fcea7
to
e5fd72e
Compare
hi-ogawa
force-pushed
the
feat-rsc-vite-6
branch
3 times, most recently
from
August 31, 2024 05:18
56164ee
to
0069ba5
Compare
hi-ogawa
force-pushed
the
chore-vite-6
branch
from
September 11, 2024 21:39
19fe095
to
fc1462c
Compare
hi-ogawa
force-pushed
the
feat-rsc-vite-6
branch
from
September 11, 2024 21:40
131392f
to
8c832eb
Compare
hi-ogawa
force-pushed
the
chore-vite-6
branch
from
September 11, 2024 22:27
fc1462c
to
7753bf9
Compare
hi-ogawa
force-pushed
the
feat-rsc-vite-6
branch
from
September 11, 2024 22:27
8c832eb
to
122e512
Compare
hi-ogawa
force-pushed
the
chore-vite-6
branch
from
September 22, 2024 08:43
7753bf9
to
b762dd9
Compare
hi-ogawa
force-pushed
the
feat-rsc-vite-6
branch
from
September 22, 2024 08:43
122e512
to
bef7489
Compare
This reverts commit 6698ab3.
hi-ogawa
force-pushed
the
chore-vite-6
branch
from
September 24, 2024 08:30
d97fa46
to
58f541a
Compare
hi-ogawa
force-pushed
the
feat-rsc-vite-6
branch
from
September 24, 2024 08:30
8123891
to
8f17204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
reactServer -> reactServerRunner
this.environment.name === "react-server"
serverDepsConfigPlugin
validateImportPlugin
buildOrchestrationPlugin
vitePluginServerAssets
,serverAssetsPluginServer
routeManifestPluginServer
environments.client
andenvironments.ssr
configthis.environment.name
switch)vite build --app
from orchestrating duringwriteBundle
feedback? bug?
resolve.noExternal
was unstable due tocrawlFrameworkPkgs
, but this array is not normalized by Vite's hashingapplyToEnvironment
is clumsy?